Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include indigo without render module into ketcher-standalone build process #5190

Closed
rrodionov91 opened this issue Jul 29, 2024 · 1 comment · Fixed by #5212
Closed

Include indigo without render module into ketcher-standalone build process #5190

rrodionov91 opened this issue Jul 29, 2024 · 1 comment · Fixed by #5212
Assignees
@rrodionov91
Labels
feature request
Milestone
Ketcher 2.24.0-rc.1

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Jul 29, 2024 •
edited
Loading

Background
Indigo implemented additional module without render part. It should be included in ketcher-standalone package.

Solution
Adjust ketcher-standalone build process to include indigo without render. Similar changes was introduced in #2654 for indigo with separated wasm file.
Provide an ability to load ketcher with indigo without render module, and then load full indigo in background.
@rrodionov91 rrodionov91 self-assigned this Jul 29, 2024
rrodionov91 added a commit that referenced this issue Aug 3, 2024
@rrodionov91
#5190 - Include indigo without render module into ketcher-standalone …
8e7fe4f 
…build process

- added ketcher-standalone builds for indigo without render module
- added structService reinitialization
@rrodionov91 rrodionov91 linked a pull request Aug 3, 2024 that will close this issue
#5190 - Include indigo without render module into ketcher-standalone build process #5212
Merged
9 tasks
@rrodionov91 rrodionov91 mentioned this issue Aug 3, 2024
Closed
rrodionov91 added a commit that referenced this issue Aug 5, 2024
@rrodionov91
#5190 - Include indigo without render module into ketcher-standalone …
b24d43a 
…build process

- added ketcher-standalone builds for indigo without render module
- added structService reinitialization
rrodionov91 added a commit that referenced this issue Aug 6, 2024
@rrodionov91
#5190 - Include indigo without render module into ketcher-standalone …
e0aaa0d 
…build process (#5212)

- added ketcher-standalone builds for indigo without render module
- added structService reinitialization
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#5190 - Include indigo without render module into ketcher-standalone …
51b0bba 
…build process (#5212)

- added ketcher-standalone builds for indigo without render module
- added structService reinitialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
feature request
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5190 - Include indigo without render module into ketcher-standalone build process epam/ketcher
2 participants
@rrodionov91 @AlexeyGirin