Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings - Preview images of structures (Templates Library, FG Library) do not respect global display settings #900

Closed
vitalgerko opened this issue Oct 29, 2021 · 3 comments · Fixed by #980, #1062 or #1065
Closed

Settings - Preview images of structures (Templates Library, FG Library) do not respect global display settings #900

vitalgerko opened this issue Oct 29, 2021 · 3 comments · Fixed by #980, #1062 or #1065
Assignees
@karen-sarkisyan @AllaZhbanova
Labels
bug Priority: Low
Milestone
Release 2.5.0

Comments

@vitalgerko
Copy link

Steps to Reproduce

  1. Launch Ketcher with the following display settings (settings: 'Atoms', 'Show hydrogen labels' - on).
  2. Open FG Library.
  3. Add FG on canvas and Expanded FG abb.
  4. Change settings: 'Atoms', 'Show hydrogen labels' - on).
  5. Open Templates Library.
  6. Add any Template on canvas.

Expected behavior
When Launch Ketcher with the following display settings (settings: 'Atoms', 'Show hydrogen labels' - on)
all structures (in FG Library and in Templates Library) should be displayed according to these settings.

Actual behavior
In FG Library and Templates Library, preview images of structures do not respect global display settings.

Settings.-.Preview.images.of.structures.Templates.Library.FG.Library.do.not.respect.global.display.settings.mp4

Desktop:
OS: Windows 10
Browser: Chrome Version 93.0.4577.63, Firefox Version 92.0, Microsoft Edge Version 93.0.961.47
@IliaVeselov IliaVeselov self-assigned this Nov 10, 2021
@AndreiMazol AndreiMazol added this to the Release 2.4.0 milestone Nov 11, 2021
@IliaVeselov IliaVeselov removed their assignment Nov 15, 2021
@dmitrii-kliushentsev dmitrii-kliushentsev linked a pull request Nov 17, 2021 that will close this issue
#900 Preview images of structures (Templates Library, FG Library) do not respect global display settings #980
Merged
AndreiMazol pushed a commit that referenced this issue Nov 18, 2021
@dmitrii-kliushentsev
#900 Preview images of structures (Templates Library, FG Library) do …
372f524 
…not respect global display settings (#980)

* fix: preview image of structures in FG Library

* fix: delete prerender

* refactor: remove selector to template file
@AllaZhbanova
Copy link

AllaZhbanova commented Dec 2, 2021 •
edited
Loading

The issue is still reproducible on v. 2.4 and v. 2.5

2021-12-02_17h23_10.mp4

@AllaZhbanova AllaZhbanova reopened this Dec 2, 2021
@karen-sarkisyan karen-sarkisyan mentioned this issue Dec 6, 2021
Merged
@AndreiMazol AndreiMazol linked a pull request Dec 6, 2021 that will close this issue
#900 Structure previews display hydrogen if settings specify it #1062
Merged
@AllaZhbanova
Copy link

The issue is reproducible if set settings : 'Atoms', 'Show hydrogen labels' - off
Open Templates and click edit

Result: hydrogen label is shown
Expected result: hydrogen label is not shown

@karen-sarkisyan karen-sarkisyan linked a pull request Dec 8, 2021 that will close this issue
#900 Template editor respects global display settings #1065
Merged
@AllaZhbanova
Copy link

Fixed, tested v.2.5

@rrodionov91 rrodionov91 mentioned this issue Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karen-sarkisyan karen-sarkisyan

@AllaZhbanova AllaZhbanova

Labels
bug Priority: Low
Projects
None yet
Milestone
Release 2.5.0
6 participants
@karen-sarkisyan @AndreiMazol @IliaVeselov @vitalgerko @AllaZhbanova @dmitrii-kliushentsev