Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotests: #3016 - create autotests for easy to implement TCses #3016

Merged
merged 16 commits into from
Sep 28, 2023

Conversation

krakmielepam
Copy link
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"

@krakmielepam krakmielepam changed the title Add EPMLSOPKET-2954&EPMLSOPKET-2955 Add EPMLSOPKET-2954&2955 Aug 1, 2023
@krakmielepam krakmielepam changed the title Add EPMLSOPKET-2954&2955 #3016 - Add test cases EPMLSOPKET-2954&2955 to Templates Aug 2, 2023
@krakmielepam krakmielepam linked an issue Aug 2, 2023 that may be closed by this pull request
@krakmielepam krakmielepam changed the title #3016 - Add test cases EPMLSOPKET-2954&2955 to Templates #3016 - create autotests for easy to implement TCses Aug 3, 2023
@Zhirnoff Zhirnoff changed the title #3016 - create autotests for easy to implement TCses Autotests: #3016 - create autotests for easy to implement TCses Aug 8, 2023
Comment on lines 691 to 695
await pressButton(page, STRUCTURE_LIBRARY_BUTTON_NAME);
await page.getByRole('tab', { name: 'Functional Groups' }).click();
await selectFunctionalGroups(FunctionalGroups.Bn, page);
await page.mouse.click(clickCoordines.x1, clickCoordines.y1);
await resetCurrentTool(page);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please try to move this code in separate function? Because it used 4 times here

- updated snapshots;
- added functions to 'templateModals.ts'
@Nitvex Nitvex merged commit 90f63cd into master Sep 28, 2023
5 checks passed
@Nitvex Nitvex deleted the 2924K-Create-autotests-for-Templates branch September 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autotests: Сreate autotests for easy to implement TCses
6 participants