-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotests: #3016 - create autotests for easy to implement TCses #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakmielepam
requested review from
AleksandraSmolianinova,
Ustianskii,
Vehemen,
Zhirnoff,
y-holik and
MartaWilliams
as code owners
August 1, 2023 18:33
krakmielepam
changed the title
Add EPMLSOPKET-2954&EPMLSOPKET-2955
Add EPMLSOPKET-2954&2955
Aug 1, 2023
krakmielepam
changed the title
Add EPMLSOPKET-2954&2955
#3016 - Add test cases EPMLSOPKET-2954&2955 to Templates
Aug 2, 2023
krakmielepam
changed the title
#3016 - Add test cases EPMLSOPKET-2954&2955 to Templates
#3016 - create autotests for easy to implement TCses
Aug 3, 2023
kaluginserg
reviewed
Aug 3, 2023
...s---Functional-Group-Tools3-Check-layout-and-cleanup-buttons-tool-on-FG-2-chromium-linux.png
Outdated
Show resolved
Hide resolved
…uttons-tool-on-FG-2-chromium-linux.png
MartaWilliams
approved these changes
Aug 8, 2023
Zhirnoff
changed the title
#3016 - create autotests for easy to implement TCses
Autotests: #3016 - create autotests for easy to implement TCses
Aug 8, 2023
rrodionov91
reviewed
Aug 22, 2023
Comment on lines
691
to
695
await pressButton(page, STRUCTURE_LIBRARY_BUTTON_NAME); | ||
await page.getByRole('tab', { name: 'Functional Groups' }).click(); | ||
await selectFunctionalGroups(FunctionalGroups.Bn, page); | ||
await page.mouse.click(clickCoordines.x1, clickCoordines.y1); | ||
await resetCurrentTool(page); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please try to move this code in separate function? Because it used 4 times here
…reate-autotests-for-Templates
- updated snapshots; - added functions to 'templateModals.ts'
Zhirnoff
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name