#3221 - add shortcut shift+tab for switching selection mode #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
chgayane,
KonstantinEpam23 and
ViktoriaTkacheva
chgayane
approved these changes
Sep 12, 2023
…d-shortcut-shift+tab-for-switching-selection-mode
ViktoriaTkacheva
approved these changes
Sep 13, 2023
…ut-shift+tab-for-switching-selection-mode
StarlaStarla
force-pushed
the
3221-add-shortcut-shift+tab-for-switching-selection-mode
branch
from
be0f277
to
374cd3a
Compare
Nitvex
reviewed
Sep 15, 2023
|
|
||
| test.describe('Hot keys', () => { | ||
| test.beforeEach(async ({ page }) => { | ||
| await page.goto(''); |
There was a problem hiding this comment.
Could you, please use waitForPageInit?
There was a problem hiding this comment.
If you use waitForPageInit, there is no need to use await page.goto('') as it is already inside that function
Nitvex
reviewed
Sep 15, 2023
ketcher-autotests/tests/User-Interface/Hot-Keys/hotkeys.spec.ts
Outdated
Show resolved
Hide resolved
…d-shortcut-shift+tab-for-switching-selection-mode
StarlaStarla
force-pushed
the
3221-add-shortcut-shift+tab-for-switching-selection-mode
branch
from
a8f026a
to
d20c334
Compare
StarlaStarla
force-pushed
the
3221-add-shortcut-shift+tab-for-switching-selection-mode
branch
from
32dddfc
to
a26a44e
Compare
Nitvex
reviewed
Sep 18, 2023
| @@ -0,0 +1,36 @@ | |||
| /* eslint-disable no-magic-numbers */ | |||
There was a problem hiding this comment.
Can you remove this line? I don't see any magic numbers here
Nitvex
approved these changes
Sep 18, 2023
Nitvex
reviewed
Sep 18, 2023
| await selectNestedTool(page, SelectTool.FRAGMENT_SELECTION); | ||
| await selectTool(LeftPanelButton.AddText, page); | ||
| await page.keyboard.press('Escape'); | ||
| expect(page.getByTestId('select-fragment')).toBeVisible(); |
There was a problem hiding this comment.
I see these two tests are failing. Could you, please, add await for expect? https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-be-visible
…ut-shift+tab-for-switching-selection-mode
Nitvex
deleted the
3221-add-shortcut-shift+tab-for-switching-selection-mode
branch
|
Preview. No comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Ketcher.v2.15.0.Vite.-.Google.Chrome.2023-09-12.10-40-57.mp4
Check list
#1234 – issue name