Macro: #3537 - default presets do not appear back after cleaning search field #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgayane
changed the title
auto-assign
bot
requested review from
OlgaMazurina,
rrodionov91 and
ViktoriaTkacheva
rrodionov91
approved these changes
Nov 20, 2023
| @@ -47,7 +49,7 @@ export const RnaBuilder = ({ libraryName }) => { | |||
| useEffect(() => { | |||
| const defaultPresets: IRnaPreset[] = getDefaultPresets(monomers); | |||
| dispatch(setDefaultPresets(defaultPresets)); | |||
| }, [dispatch]); | |||
| }, [dispatch, serachValue]); | |||
There was a problem hiding this comment.
typo in word "search"
- fixed type in searchValue variable
OlgaMazurina
approved these changes
Nov 20, 2023
| @@ -65,7 +65,7 @@ const Menu = ({ | |||
|
|
|||
| return ( | |||
| <MenuContext.Provider value={context}> | |||
| <MenuLayout data-testId={testId}> | |||
| <MenuLayout data-testid={testId}> | |||
There was a problem hiding this comment.
I fixed the same line in my branch =)
rrodionov91
deleted the
3537-macro-default-presets-do-not-appear-back-after-cleaning-search-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name