Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4607 - Inconsistent display of a separate phosphate in the sequence representation in the Sequence mode #4766

Merged
merged 7 commits into from
Jun 14, 2024
Merged

#4607 - Inconsistent display of a separate phosphate in the sequence representation in the Sequence mode #4766

merged 7 commits into from
Jun 14, 2024

Conversation

DmitriiP-EPAM
Copy link
Collaborator

@DmitriiP-EPAM DmitriiP-EPAM commented Jun 6, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

Снимок экрана 2024-06-13 в 21 21 25 Снимок экрана 2024-06-13 в 21 21 32

Check list

  • unit-tests written
  • e2e-tests written (snapshots have been updated)
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@DmitriiP-EPAM DmitriiP-EPAM self-assigned this Jun 6, 2024
@DmitriiP-EPAM DmitriiP-EPAM linked an issue Jun 6, 2024 that may be closed by this pull request
Inconsistent display of a separate phosphate in the sequence representation in the Sequence mode #4607
Closed
@DmitriiP-EPAM DmitriiP-EPAM force-pushed the 4607-inconsistent-display-of-a-separate-phosphate-in-the-sequence-representation-in-the-sequence-mode branch from 67d8c3d to 7eaa04c Compare June 13, 2024 17:51
@DmitriiP-EPAM
#4607 - Bugfix (monomers.ts): Correct isValidNucleoside(1), `isVali…
022dce8 
…dNucleotide(1)`
@DmitriiP-EPAM
#4607 - Bugfix (Chain.ts): Correct the definition of individual phosp…
d050f10 
…hate and linker in `add(1)`
@DmitriiP-EPAM
#4607 - Bugfix (monomers.ts): Correct isValidNucleoside(1), `isVali…
b03cbf3 
…dNucleotide(1)` (step 2)
@DmitriiP-EPAM
#4607 - Bugfix (Chain.ts): Correct the definition of individual phosp…
94ae1b0 
…hate and linker in `add(1)` (step 2)
@DmitriiP-EPAM
#4607 - Test (Import-Saving-Files): Run `npm run docker:update Import…
2a45a3f 
…-Saving-Files/saving-svg.spec.ts`
@DmitriiP-EPAM
#4607 - Test (sequence-mode.spec.ts): Run `npm run docker:update sequ…
353c817 
…ence-mode.spec.ts:393`
@DmitriiP-EPAM
#4607 - Test (Sequence-Mode): Run `npm run docker:update Sequence-Mod…
2b2e9fd 
…e/sequence-mode.spec.ts:671`
@DmitriiP-EPAM DmitriiP-EPAM force-pushed the 4607-inconsistent-display-of-a-separate-phosphate-in-the-sequence-representation-in-the-sequence-mode branch from 5b51afb to 2b2e9fd Compare June 14, 2024 11:55
@rrodionov91 rrodionov91 merged commit 22ad484 into master Jun 14, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4607-inconsistent-display-of-a-separate-phosphate-in-the-sequence-representation-in-the-sequence-mode branch June 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrodionov91 rrodionov91 rrodionov91 approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@ilya-asiyuk-epam ilya-asiyuk-epam Awaiting requested review from ilya-asiyuk-epam

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent display of a separate phosphate in the sequence representation in the Sequence mode
2 participants
@DmitriiP-EPAM @rrodionov91