#5512 - System saves mixture ambiguous monomers as alternatives ambiguous monomers #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uous monomers - fixed template id generation for ambiguous monomers
auto-assign
bot
requested review from
AlexeyGirin,
NataliaLoginova and
svvald
rrodionov91
changed the title
svvald
approved these changes
Sep 16, 2024
| '_' + | ||
| option.templateId + | ||
| '_' + | ||
| (option.probability || option.ratio || ''), |
There was a problem hiding this comment.
If both probability and ratio are not defined, we will end up with string having underscore in the end: 'TemplateId_TemplateId_'. I'm not sure if this case is possible and if so, will it affect anything, just wanted to highlight
There was a problem hiding this comment.
Thanks, it should not affect I think
rrodionov91
deleted the
5512-system_saves_mixture_ambiguous_monomers_as_alternatives_ambiguous_monomers
branch
rrodionov91
added a commit
that referenced
this pull request
Sep 16, 2024
…uous monomers (#5516) - fixed template id generation for ambiguous monomers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Check list
#1234 – issue name