Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker disabled color #174

Closed
Pcothren opened this issue Jan 31, 2021 · 0 comments · Fixed by #175
Closed

DatePicker disabled color #174

Pcothren opened this issue Jan 31, 2021 · 0 comments · Fixed by #175

Comments

@Pcothren
Copy link
Contributor

Issue

DatePicker is using disable text color to color the button. This prevents the user from being able to change the selected dates color without also changing the inactive date color.

implot/implot.cpp

Lines 3881 to 3886 in e64df65

ImGui::PushStyleColor(ImGuiCol_Button, ImVec4(0,0,0,0));
ImGui::PushStyleVar(ImGuiStyleVar_ItemSpacing, ImVec2(0,0));
ImGuiStyle& style = ImGui::GetStyle();
ImVec4 col_txt = style.Colors[ImGuiCol_Text];
ImVec4 col_dis = style.Colors[ImGuiCol_TextDisabled];

implot/implot.cpp

Line 3972 in e64df65

ImGui::PushStyleColor(ImGuiCol_Button, col_dis);

implot/implot.cpp

Line 4022 in e64df65

ImGui::PushStyleColor(ImGuiCol_Button, col_dis);

implot/implot.cpp

Line 4060 in e64df65

ImGui::PushStyleColor(ImGuiCol_Button, col_dis);

Suggested Fix

separate selected date button color and disabled date text color. Allowing better integration with themes and more freedom for the user.

Pcothren added a commit to Pcothren/implot that referenced this issue Jan 31, 2021
Separate disabled color from the selected date to the truly disabled dates in another month. Move setting col/styles after we are done getting them.
Ben1138 pushed a commit to Ben1138/implot that referenced this issue Oct 2, 2024
Separate disabled color from the selected date to the truly disabled dates in another month. Move setting col/styles after we are done getting them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant