Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click event filters #22

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Click event filters #22

merged 3 commits into from
Dec 20, 2023

Conversation

PaulC91
Copy link
Member

@PaulC91 PaulC91 commented Dec 20, 2023

adds click event filtering functionality to the time and place modules.

Also:

  • removes full mapview dependency by copying all functions required for mapshot2 into this package
  • updates to the person population pyramid chart are now done via a highchartProxy
  • group filters are now rendered on launch then updated server-side to avoid the second delay rendering them server-side

@PaulC91
test click event filtering across modules
8a12c9a
@PaulC91
time and place click event filters ready
602e5f9 
need to figure out how to reset module click filters via the filter module reset button without invalidating the module's reactive data
@PaulC91
update pyramid chart via proxy
384c69c 
also remove mapview dependency and a bunch of other small improvements
@PaulC91 PaulC91 merged commit 28ef653 into main Dec 20, 2023
1 check failed
@PaulC91 PaulC91 deleted the click-event-filters branch December 20, 2023 18:40
@PaulC91 PaulC91 mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaulC91