docs: fix fonts loading #3492
Merged
docs: fix fonts loading #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zvenigorodskaia. I'll need a PNG image of preview-features.svg. SVG is 600kb, png is 60kb or 20kb compressed with https://tinypng.com |
asvae
force-pushed
the
fix#3420/docs-fonts
branch
from
c62067a
to
68824f9
Compare
asvae
requested changes
Jun 19, 2023
There was a problem hiding this comment.
I did some checking and:
Lighthouse gives pretty much identical results (you can check https://ui-experimental.vuestic.dev and https://ui-develop.vuestic.dev/)
Performance tests also didn't show any significant advantage:
For both cases I did about 5 tests and number were pretty similar. So I'm not sure if we improved anything performance wise.
What I noticed is that there is much less screen permutations, which is a good thing. There was only one left - two times fonts are updated (for components and across the page):
Also icon disappeared:
|
Must be ok now: |
asvae
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved FCP and overall lighthouse score.
closes #3420