Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automated display of badges #3538

Merged
merged 6 commits into from
Jun 27, 2023
Merged

feat: automated display of badges #3538

merged 6 commits into from
Jun 27, 2023

Conversation

thesheppard
Copy link
Contributor

@thesheppard thesheppard commented Jun 23, 2023 •
edited by m0ksem
Loading

Description

closes #3528
closes #3546

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@thesheppard
Copy link
Contributor Author

@asvae Not too sure how to assign somebody to this PR
Tagging you since you created the issue 🖖🏾

@thesheppard thesheppard mentioned this pull request Jun 26, 2023
Closed
@m0ksem m0ksem self-requested a review June 26, 2023 10:29
@m0ksem m0ksem added the docs packages/docs label Jun 27, 2023
@m0ksem
Copy link
Collaborator

m0ksem commented Jun 27, 2023 •
edited
Loading

Hi, @thesheppard! Thanks for PR! I simplified a bit these changes. It will be much easier for us to have badge logic outside of navigationRoute file, so we store only configuration here.

And now it also closes #3546

@m0ksem m0ksem merged commit ec89a28 into epicmaxco:develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem approved these changes

Assignees

@thesheppard thesheppard

Labels
docs packages/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update NEW label in docs for 1.7 Automated display of badges
2 participants
@thesheppard @m0ksem