Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add native autocomplete attribute support #4370

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

padinko
Copy link
Contributor

@padinko padinko commented Sep 3, 2024

Description

Add support for native <input autocomplete=...> attribute. Docs.
This attribute is very necessary to handle autofilling forms (like login/register/address/...)

Markup:

<VaInput
    v-model="form.username"
    :label="t('username')"
    required
    autofocus
    autocomplete="username"
/>

<VaInput
    v-model="form.password"
    type="password"
    :label="t('password')"
    required
    autocomplete="current-password"
/>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit c284e7a
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/66d6cb53e721680008bcc8b5
😎 Deploy Preview https://deploy-preview-4370--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for vuestic-docs ready!

Name Link
🔨 Latest commit c284e7a
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-docs/deploys/66d6cb5350f9bb0008c0d4ce
😎 Deploy Preview https://deploy-preview-4370--vuestic-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m0ksem m0ksem self-requested a review September 10, 2024 08:48
@m0ksem
Copy link
Collaborator

m0ksem commented Sep 13, 2024

Thanks!

@m0ksem m0ksem merged commit ff822e7 into epicmaxco:develop Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants