Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VaToast #4373): add bottom-center, top-center position options #4377

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

tom00502
Copy link
Contributor

@tom00502 tom00502 commented Sep 11, 2024

Add bottom-center, top-center position options to VaToast

Description

Two new position options have been added to Vatoast: 'top-center' and 'bottom-center'.

closes #4373

'top-center': Displays the toast at the top center of the screen.
'bottom-center': Displays the toast at the bottom center of the screen.
The Y-axis shift overlay and fade-out animation when the toast appears have been taken into account.

In order to handle the relationship of the animation starting point, it was necessary to add the 'center' class to the toast for these two options.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for vuestic-docs ready!

Name Link
🔨 Latest commit 6c27584
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-docs/deploys/66e7de0fff5b8f00085b2a44
😎 Deploy Preview https://deploy-preview-4377--vuestic-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57
Accessibility: 98
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit 6c27584
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/66e7de0f72c18d0008d41da3
😎 Deploy Preview https://deploy-preview-4377--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m0ksem
Copy link
Collaborator

m0ksem commented Sep 16, 2024

2024-09-16 at 10 27 54 - Cyan Anaconda

I updated missing animations.

@m0ksem m0ksem merged commit 5b53670 into epicmaxco:develop Sep 23, 2024
10 checks passed
m0ksem added a commit that referenced this pull request Oct 17, 2024
…4377)

* feat(VaToast #4373): add bottom-center, top-center position options

* fix: correctly handle multiple toasts offset

* chore(toast): fix paddings

* chore: remove redundant

* fix(toast): improve appear and close animations

---------

Co-authored-by: Parsons <[email protected]>
Co-authored-by: Maksim Nedoshev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaToast add bottom-center, top-center position options
2 participants