Tables #22
Merged
Tables #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently only static tables. There is a problem with the device schema test which I have not yet investigated. |
GDYendell
force-pushed
the
tables
branch
2 times, most recently
from
7057dcc
to
648e18a
Compare
|
As far as inspecting the display in phoebus without real PVs to point at I think Tables and ComboBox-with-choices both work now. Is someone else waiting to try this or is there something I can test? |
|
Note I would like to refactor the now 1000+ line |
GDYendell
commented
Feb 27, 2023
GDYendell
force-pushed
the
tables
branch
2 times, most recently
from
deeb4c8
to
d0640f7
Compare
GDYendell
force-pushed
the
tables
branch
2 times, most recently
from
d112716
to
45b4f20
Compare
GDYendell
force-pushed
the
tables
branch
2 times, most recently
from
3c546be
to
225087f
Compare
GDYendell
force-pushed
the
tables
branch
4 times, most recently
from
277f080
to
b2993ea
Compare
|
@coretl this is ready now. I am not sure to what extent you want to review this, as it is a big diff, but I would appreciate comments on Refactor _format module as to whether you think it makes things clearer or not. |
GDYendell
force-pushed
the
tables
branch
2 times, most recently
from
a0fe350
to
452116d
Compare
- Rename classes and methods
- Use Factory for classes that have methods to create class instances
- Use Formatter for classes that have a format method that produces
a text representation of a widget for a UI file. This distinguishes
from Device Widgets that determine the widget that will be created
for a Signal.
- Class renames:
- WidgetTemplate -> UITemplate
- WidgetFactory -> WidgetFormatter
- GroupFactory -> GroupWidgetFormatter
- LayoutProperties -> ScreenLayout
- ScreenWidgets -> WidgetFormatterFactory
- Screen -> ScreenFormatterFactory
- Screen method renames:
- screen -> create_screen_formatter
- create_sub_screens -> create_sub_screen_formatters
- component -> generate_component_formatters
- make_group_widget -> create_group_formatters
- group -> create_group_formatter
- make_component_widgets -> create_component_widget_formatters
- Make passing of ui properties to formatter more explicit and pass
widget to formatter as a parameter separate to the properties map
- Expand one character variables
- mypy fixes
- Update docs ref
Add 3.10 to setup.cfg, as it is tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
choicestoComboBoxand make phoebus support it #25