upper bound frac_obs by 1
#340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks usage in our UK modelling pipeline where the fraction reported is used as an additional noise parameter for IEU bed usage but I agree better matches the definition as stated. |
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently described ("fraction...that are ultimately observed") the
frac_obsvariable should have an upper bound of 1. This helps constraining it when usingestimate_secondaryto estimate the scaling between two time serires.There might be use cases where one would want to allow the parameter to extend beyond 1, in which case the upper bound could be made optional and the parameter description/name changed.