Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to directly calculated growth rate and extend model options, take 2 #345

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jan 18, 2023

Attempts to resurrect #307 as work in progress. Copying text from there:

This PR is meant to supersede #213 and #214. It

Things left to do:

  • expose and document the model options and ensure the stan model options are set consistently
  • Update the README so that it works.
  • Remove backcalc_opts() from all input
  • Remove rt_opts() from all input
  • Move generation_time_opts() inside of process_opts() as an argument.
  • Check postprocessing works as expected
  • Check that all examples and docs work as expected
  • Document model based on update specification
  • Get passing CRAN check if not already
  • more extensive testing
  • update NEWS

@sbfnk sbfnk mentioned this pull request Jan 27, 2023
@seabbs seabbs force-pushed the update_growth_and_generation branch from 40709d2 to 8fe772a Compare January 27, 2023 14:05
@seabbs seabbs mentioned this pull request Jan 27, 2023
16 tasks
Base automatically changed from develop to main April 27, 2023 08:36
@sbfnk sbfnk force-pushed the update_growth_and_generation branch from 1e5e88c to 998cadd Compare July 4, 2023 20:01
@sbfnk sbfnk mentioned this pull request Jul 18, 2023
18 tasks
@sbfnk sbfnk mentioned this pull request Oct 30, 2023
@sbfnk sbfnk force-pushed the main branch 2 times, most recently from 7568882 to 23229a8 Compare February 19, 2024 20:09
@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 21, 2024

To do for being able to revisit this:

  • rebase to main
  • reduce the number of models to 2 (growth rate model is the same as renewal model with fixed generation time of 1)
    and then go back to the items in the original issue

seabbs and others added 7 commits May 17, 2024 08:05
implements suggestions by @hsbadr

See
#213 (comment)
#213 (comment)
#213 (comment)

For now not implementing comparison to the approximate growth rate as
this seems quite a specific use case that could also be done outside the
stan model.

Also not implementing any approximate growth rate from seeding time -
instead minimum seeding time is now set to 1, so the last seeding time
is used to calculate the first growth rate.
…erything on the log scale as long as possible)
@sbfnk sbfnk force-pushed the update_growth_and_generation branch from 998cadd to e543808 Compare May 17, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants