-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed up generation of infections #416
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8929be0 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 59dae8e is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note this may reduce stability in contexts with problematic data which were the motivation for adding these padding values.
I was wondering about that, thinking that it would have been mitigated by |
Potentially though it was largely issues in warm-up from the likelihood vs in the generated quantities. I think given pathfinder will soon be out many of these issues with stability are likely soon to be resolved. |
implements suggestions from #415