Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore alpha prior SD to 0.05 #840

Merged
merged 3 commits into from
Oct 30, 2024
Merged

restore alpha prior SD to 0.05 #840

merged 3 commits into from
Oct 30, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 29, 2024

Description

This PR closes #834.

Still happy to review/reconsider if other values might work better.

I think I've got the squares / square roots right (and fixed them in the old news item) but may have got confused.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

NEWS.md Outdated Show resolved Hide resolved
jamesmbaazam
jamesmbaazam previously approved these changes Oct 30, 2024
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This all seems to come down to advising users to explore different values and not rely on the default values.

@sbfnk sbfnk added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 24d08fd Oct 30, 2024
9 checks passed
@sbfnk sbfnk deleted the alpha-sd-gp branch October 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sd of prior of alpha
2 participants