Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #486: Add startup message for a new CRAN release #490

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Nov 20, 2023

Fixes #486

Update: After discussing this with @sbfnk I removed the specific release date and replaced it by "first quarter of 2024" as that gives us a bit more room and freedom. See #493 for a plan of future development steps. There is still some uncertainty about which issues should be part of which release and how best to avoid too many breaking changes on CRAN.

This PR adds a new startup message to the package warning users of upcoming changes and announcing a planned release date (February 1 2024), as well as asking them for feedback (by linking to the discussion here: #333)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e849d60) 90.87% compared to head (4a8fb92) 90.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   90.87%   90.91%   +0.03%     
==========================================
  Files          22       23       +1     
  Lines        1392     1398       +6     
==========================================
+ Hits         1265     1271       +6     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse mentioned this pull request Nov 22, 2023
30 tasks
@nikosbosse nikosbosse mentioned this pull request Nov 24, 2023
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit d5ea584 into main Nov 25, 2023
11 checks passed
@nikosbosse nikosbosse deleted the issue-486-cran-release branch November 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN release
2 participants