Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR template #491

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Create a PR template #491

merged 4 commits into from
Nov 27, 2023

Conversation

nikosbosse
Copy link
Contributor

Ruthlessly stealing from epinowcast this PR adds a PR template for new PRs to follow.
For the last time ever, with this PR, I enjoy the freedom of writing whatever I want in a pull request. Alas, I am not to be trusted and including a PR template will hopefully include the quality of future PRs by providing an explicit checklist for things to do and think about before opening a PR.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e849d60) 90.87% compared to head (bf70109) 90.92%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   90.87%   90.92%   +0.04%     
==========================================
  Files          22       23       +1     
  Lines        1392     1399       +7     
==========================================
+ Hits         1265     1272       +7     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse mentioned this pull request Nov 24, 2023
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit 3db7de1 into main Nov 27, 2023
11 checks passed
@nikosbosse nikosbosse deleted the create-PR-template branch November 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants