Rename environment variable to rails convention #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have erroneously been using RELATIVE_URL_ROOT in place of the conventional RAILS_RELATIVE_URL_ROOT which has the added side effect of setting Rails.application.config.application_controller.relative_url_root which in turn prepends all routes generated by url_helpers. Test by starting rails console with RAILS_RELATIVE_ROOT_URL set include Rails.application.routes.url_helpers and call root_path
|
These changes will be made as part of #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have erroneously been using RELATIVE_URL_ROOT in place of the
conventional RAILS_RELATIVE_URL_ROOT which has the added side effect of
setting Rails.application.config.application_controller.relative_url_root which
in turn prepends all routes generated by url_helpers.
Test by starting rails console with RAILS_RELATIVE_ROOT_URL set.
include Rails.application.routes.url_helpers and call root_path
Addresses epimorphics/hmlr-linked-data#52