Skip to content

Commit

Permalink
Merge pull request #437 from epimorphics/spike/update-label-to-be-cli…
Browse files Browse the repository at this point in the history
…ckable

Updates label to be clickable
  • Loading branch information
DanielCouzens authored Sep 4, 2024
2 parents f41eb58 + 83153fe commit 1b54530
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 1.7.5 - 2024-09

- (Dan) Updates the property table ui so the label is clickable
- (Dan) Replaces the buttons for checkboxes on the property tables [GH-431](https://github.com/epimorphics/ukhpi/issues/431)
- (Jon) Exposed `instrument_internal_error(exception)` metric to the
`ExceptionsController` to provide a count of internal errors
Expand Down Expand Up @@ -40,7 +41,7 @@
- (Dan) Fixed aria-label in compare locations form [GH-416](https://github.com/epimorphics/ukhpi/issues/416)
- (Dan) Adds `aria-label` link attributes on the about page to SPARQL link
[GH-413](https://github.com/epimorphics/ukhpi/issues/413)
- (Bogdan) Fixed a bug where CSS was being applied to the wrong element
- (Bogdan) Fixed a bug where CSS was being applied to the wrong element
[GH-412](https://github.com/epimorphics/ukhpi/issues/412)
- (Bogdan) Fixed type in aria-label text [GH-416](https://github.com/epimorphics/ukhpi/issues/416)
- (Bogdan) Fixed a duplicate character bug when selecting dates
Expand Down
3 changes: 3 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ GEM
nio4r (2.5.9)
nokogiri (1.13.10-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.13.10-x86_64-linux)
racc (~> 1.4)
oj (3.14.2)
parallel (1.22.1)
parser (3.1.1.0)
Expand Down Expand Up @@ -363,6 +365,7 @@ GEM

PLATFORMS
x86_64-darwin-21
x86_64-linux

DEPENDENCIES
byebug
Expand Down
3 changes: 2 additions & 1 deletion app/javascript/components/data-view-statistics.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
>
<input
type="checkbox"
:id="'checkbox-' + statistic.slug"
:name='statistic.label'
:data-slug='statistic.slug'
@change='onSelectStatistic'
:checked='isSelectedStatistic(statistic.slug)'
/>
<label :for='statistic.label'>
<label :for="'checkbox-' + statistic.slug">
<img
:src='imageSrcPath(index, false)'
:srcset='imageSrcPath(index, true)'
Expand Down

0 comments on commit 1b54530

Please sign in to comment.