Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UKHPI - 1.3.1: Info and Relationships #405

Closed
bogdanadrianmarc opened this issue Aug 5, 2024 · 13 comments
Closed

UKHPI - 1.3.1: Info and Relationships #405

bogdanadrianmarc opened this issue Aug 5, 2024 · 13 comments
Assignees

Comments

@bogdanadrianmarc
Copy link
Contributor

bogdanadrianmarc commented Aug 5, 2024

See https://docs.google.com/spreadsheets/d/1YS3N5ps9pJGFOxBDi9C2DwA37WQPIVax/edit?gid=1215429860#gid=1215429860&range=6:6

@bogdanadrianmarc bogdanadrianmarc self-assigned this Aug 8, 2024
@bogdanadrianmarc
Copy link
Contributor Author

@tomguilbert The requirement for this ticket is to provide a summary of the information displayed on the graph. However, this is already achieved by the data table in an accessible manner, as shown here:
Image

I propose to close this as completed, unless there is something else to be addressed.

@tomguilbert
Copy link

@bogdanadrianmarc - could there be a pointer for screen reader users from the graph to the table, so they understand that they can get a more accessible version fo the information there?

@bogdanadrianmarc
Copy link
Contributor Author

@bogdanadrianmarc - could there be a pointer for screen reader users from the graph to the table, so they understand that they can get a more accessible version fo the information there?

Sure thing! I'll look into adding something that's hidden to the normal user, but available for screen readers 👍

@bogdanadrianmarc
Copy link
Contributor Author

bogdanadrianmarc commented Aug 20, 2024

@tomguilbert I created a new PR here with the changes, let me know if these look good to you, added before and after screenshots as well

@tomguilbert
Copy link

tomguilbert commented Aug 20, 2024

@bogdanadrianmarc - I think I understand what you're trying to do here, but I think you will get tied up with other issues around logical ordering of the tabs. What I meant by my comment was could you add something to the graph description that explains that the data underlying the graph is available in more accessible form via the data tab?

@DanielCouzens
Copy link
Contributor

I have asked Gemma for some clarification on this ticket. I have been unable to find a way to add a description directly to the tabs. However, I can add a description to the tab panel and advise the user who is using a screen reader on the best way to use the tabs for accessibility.

@gemma-marriage
Copy link

gemma-marriage commented Aug 30, 2024

@DanielCouzens I agree adding a desciption to the tab panel (assuming just in the code) would solve it - that's probably best, otherwise a code snippet to the whole graph here to explain that the accessible data for the graph can be found under the 'See data table' tab a bit like this example -

image

The issue at the moment is that it's not clear that is where they can go for data in a more accessible format, so I wonder if also changing the tabs to say 'See data - graph / See data - table' or using a colon instead of a dash, may be a little clearer to all users what is beneath, but that's up to you.

@DanielCouzens
Copy link
Contributor

This is in review. Pr #433

@DanielCouzens
Copy link
Contributor

This is has been merged into dev and is ready to check @tomguilbert

@tomguilbert
Copy link

Thanks @DanielCouzens - not sure how to test this - can you give me a demo or a screenshot please?

@DanielCouzens
Copy link
Contributor

Screenshot from 2024-09-02 09-25-45

@tomguilbert if the above screenshot isn't clear, I can do a demo whenever you are free...

@DanielCouzens
Copy link
Contributor

@tomguilbert there are translations to Welsh in other areas of the App where text is specific to screenreaders! So we do need a translation for my paragraph...

@tomguilbert
Copy link

OK - this looks good for the English text so I would say we call this done but create a new ticket for the welsh translations. Could you do that and insert the English copy you want to be translated please? If you assign it to me I'll get the translation done alongside the accessibility statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants