Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/405 info and relationships #433

Merged
merged 7 commits into from
Sep 2, 2024

Conversation

DanielCouzens
Copy link
Contributor

@DanielCouzens DanielCouzens commented Aug 30, 2024

Adds hidden message for screenreaders that advises the user to use the data table tab.

Please see this ticket. #405

Screenshot from 2024-09-02 09-25-45

@DanielCouzens DanielCouzens marked this pull request as ready for review September 2, 2024 08:47
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that the accessible copy should have had the tab name in quotes in both languages; however as this has been signed off let's get this merged in! ✅

@DanielCouzens DanielCouzens merged commit 73e7710 into dev Sep 2, 2024
2 checks passed
@DanielCouzens DanielCouzens deleted the issue/405-info-and-relationships branch September 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants