Update Rails and JS dependencies #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ijdickinson
commented
Sep 29, 2020
ijdickinson
commented
- Fix sundry Rubocop warnings
- Update Ruby dependencies
- Update Javascript dependencies
- Update version and changelog
app/presenters/landing_state.rb
Outdated
| @@ -75,7 +75,7 @@ def to_value(val) | |||
| def format_percentage(change) | |||
| if change == 'unknown' | |||
| change | |||
| elsif change == 0.0 | |||
| elsif change.abs <= 0.0001 | |||
There was a problem hiding this comment.
What's this change for?
There was a problem hiding this comment.
Rubocop was whining that exact comparisons (==) on floating point numbers are unreliable. While that is true for floating point in general, it shouldn't be true for 0.0. So a better change might have been to rubocop:disable that check on that line
joescottdave
approved these changes
Sep 30, 2020
| @@ -75,7 +75,7 @@ def to_value(val) | |||
| def format_percentage(change) | |||
| if change == 'unknown' | |||
| change | |||
| elsif change == 0.0 | |||
| elsif change.zero? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.