-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 500 internal server error when trying to print data table #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using `.try(:first)` resolves by returning `nil` without failing if the requested element does not have the method `.first`, i.e. is empty
Adjusted template to include google analytics in print requests as well as carried over other improvements in header elements
Minor tweaks to the Makefile to remove duplicate variables (`SHORTNAME`) as well as introducing new targets for `check` and `local` for streamlined development tasks
from v1.7.3 ~> v1.7.4
removed `:unit` from test target as that doesn't exist
bogdanadrianmarc
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Organised specific gems into test group as well as locked gem versions to the current ruby version where applicable
Removed incorrect instructions, re-grouped build commands into the assets target, applied the same target where previously invoking manually; finally, updated the test target to use rake test and removed the system test command as it's not required at this moment
bogdanadrianmarc
approved these changes
Apr 22, 2024
set `config.cache_classes=false` to allow Spring to reload assets set `ENV['API_SERVICE_URL']` to `ENV.fetch('API_SERVICE_URL', nil)` as Rubocop continued to complain
removes auth target, as well as echos for tracking, alongside reassigning NAME instead of REPO where applicable
Closing as releasing change through the stack to verify and ensure it's updated on all instances going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the error reported in ticket #396 by updating the print presenter to use
.try(:first)
which resolves by returningnil
without failing if the requested element does not have the method.first
, i.e. is empty or nilAdditional Changes:
SHORTNAME
) as well as introducing new targets forcheck
andlocal
for streamlined development tasks, alongside removing incorrect and erroneous commands where applicablebin/s-query
file which is used to resolve the fallback location for the Apache Jena Fuseki s-query file added in this commit