Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/412 a11y #423

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Issue/412 a11y #423

merged 8 commits into from
Aug 15, 2024

Conversation

bogdanadrianmarc
Copy link
Contributor

@bogdanadrianmarc bogdanadrianmarc commented Aug 14, 2024

This PR addresses issue #412 by increasing contrast for search location results, as well as when they are being focused. Also increased contrast for compare location dropdowns

Before:
Screenshot 2024-08-14 at 16 44 31
Screenshot 2024-08-14 at 17 17 34

After:
Screenshot 2024-08-15 at 10 23 41
Screenshot 2024-08-14 at 17 21 06

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment on style choice in the location selection css

app/assets/stylesheets/_ukhpi-location-select.scss Outdated Show resolved Hide resolved
@bogdanadrianmarc
Copy link
Contributor Author

please see comment on style choice in the location selection css

Should be fixed now, re-requested review 👍

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bogdanadrianmarc bogdanadrianmarc merged commit 1ac53a2 into dev Aug 15, 2024
2 checks passed
@bogdanadrianmarc bogdanadrianmarc deleted the issue/412-a11y branch August 15, 2024 09:59
@bogdanadrianmarc bogdanadrianmarc restored the issue/412-a11y branch August 20, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants