Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Configuration Unification #446

Merged
merged 2 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 1.7.5 - 2024-09

- (Jon) Moved all mirrored configuration settings from individual environments
into the application configuration to reduce the need to manage multiple
sources of truth
- (Jon) Actioned all of the outstanding updates contained within the dependabot
#443 PR as well as all updates implemented via yarn upgrade-interactive thus
bringing the application to the highest level of update available at this time
Expand Down
10 changes: 10 additions & 0 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ class Application < Rails::Application
# Application configuration should go into files in config/initializers
# -- all .rb files in that directory are automatically loaded.

# feature flag for showing the Welsh language switch affordance
config.welsh_language_enabled = true

# Use default paths for documentation.
config.accessibility_document_path = '/accessibility'
config.privacy_document_path = '/privacy'

# Set the contact email address to Land Registry supplied address
config.contact_email_address = '[email protected]'

# Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
# Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
# config.time_zone = 'Central Time (US & Canada)'
Expand Down
10 changes: 0 additions & 10 deletions config/environments/development.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,4 @@

# API location can be specified in the environment but defaults to the dev service
config.api_service_url = ENV.fetch('API_SERVICE_URL', 'http://localhost:8888')

# feature flag for showing the Welsh language switch affordance
config.welsh_language_enabled = true

# Use default paths for documentation.
config.accessibility_document_path = '/doc/accessibility'
config.privacy_document_path = '/doc/privacy'

# Set the contact email address to Land Registry supplied address
config.contact_email_address = '[email protected]'
end
10 changes: 0 additions & 10 deletions config/environments/production.rb
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,4 @@

# API location is specified in the environment variable API_SERVICE_URL
config.api_service_url = ENV.fetch('API_SERVICE_URL', nil)

# feature flag for showing the Welsh language switch affordance
config.welsh_language_enabled = true

# Use default paths for documentation.
config.accessibility_document_path = '/accessibility'
config.privacy_document_path = '/privacy'

# Set the contact email address to Land Registry supplied address
config.contact_email_address = '[email protected]'
end
10 changes: 0 additions & 10 deletions config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,4 @@
# API location can be specified in the environment
# But defaults to the dev service
config.api_service_url = ENV.fetch('API_SERVICE_URL', 'http://localhost:8080')

# Use default paths for documentation.
config.accessibility_document_path = '/doc/accessibility'
config.privacy_document_path = '/doc/privacy'

# feature flag for showing the Welsh language switch affordance
config.welsh_language_enabled = true

# Set the contact email address to Land Registry supplied address
config.contact_email_address = '[email protected]'
end