Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Layer 2 example including interconnection and VRF #232

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Oct 3, 2024

This will eventually become a working example of deploying a Metal device in Layer 2(-ish, could be hybrid?) in a VRF with a Metal-billed VRF interconnection that goes somewhere TBD (for example, an AWS VPC endpoint for S3).

Closes #162

Copy link

github-actions bot commented Oct 3, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[WIP] Layer 2 example including interconnection and VRF". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

- name: create a VRF IP reservation
equinix.cloud.metal_reserved_ip_block:
project_id: "{{ project.id }}"
quantity: 100 # TODO should we need this?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a change to the metal_reserved_ip_block module parameter validation. The quantity field is required by project_id, and one of project_id or id is required.

Comment on lines +65 to +68
# Leaving these out causes an error that they are missin
# Including them causes an error that they are unsupported
network: 192.168.200.0
cidr: 25
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also requires changing something in the metal_reserved_ip_block module. I see these arguments defined in argument_spec but not in the variables that feed specdoc. Is that the issue, or is there a 3rd place that arguments need to be defined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an example for L2 resources
1 participant