Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metal] Can't load all pages for the FindIPReservations endpoint #18

Open
ctreatma opened this issue Jan 11, 2024 · 0 comments
Open

[Metal] Can't load all pages for the FindIPReservations endpoint #18

ctreatma opened this issue Jan 11, 2024 · 0 comments

Comments

@ctreatma
Copy link
Contributor

ctreatma commented Jan 11, 2024 •
edited
Loading

The FindIPReservations endpoint only has an Execute() method even though the endpoint is paginated.

The ExecuteWithPagination method is missing because the request object does not have a page parameter, which means there's no way to tell this generated client to fetch pages beyond 1.

The API spec for the findIPReservations path needs to be updated to reference the page parameter. There is an example of referencing the page parameter in the findProjectEvents endpoint.
@ctreatma ctreatma mentioned this issue Jan 11, 2024
Merged
@ctreatma ctreatma mentioned this issue Jan 19, 2024
Merged
cprivitere added a commit that referenced this issue Jan 19, 2024
@cprivitere
fix: add missing pagination support for FindIPReservations (#24)
5bface5 
This works around #18 by patching the local spec to define the `page`
parameter for the `findIPReservations` endpoint.
@ctreatma ctreatma changed the title Can't load all pages for the FindIPReservations endpoint [Metal] Can't load all pages for the FindIPReservations endpoint Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctreatma