chore: Updated metal-go client for sub-command twofa #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
reviewed
Aug 22, 2023
| return nil | ||
| } | ||
|
|
||
| otpURI, _, err := c.Service.SeedApp() |
There was a problem hiding this comment.
Is this subcommand no longer needed? Or is it removed because the endpoints/operations used here are not in the spec?
If we still need to support this subcommand, a short-term workaround might be to find a way to convert the other 2fa subcommands to metal-go while leaving this one on packngo.
ctreatma
reviewed
Sep 15, 2023
| @@ -48,12 +49,13 @@ func (c *Client) Enable() *cobra.Command { | |||
|
|
|||
| cmd.SilenceUsage = true | |||
| if sms { | |||
| _, err := c.Service.EnableSms(token) | |||
| _, err := c.Service.EnableTfaSms(context.Background()).Execute() | |||
There was a problem hiding this comment.
Do we need to be able to pass in the token? Is this a spec issue that needs to be fixed?
|
/assign @aayushrangwala |
displague
changed the title
|
Closing in favor of #353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakout from #270
What this PR does / why we need it:
This PR replaces packngo with metal-go for all interactions with the Equinix Metal API specifically for twofa subcommands