Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumictl and pulumi are assumed to be installed for make build #142

Closed
displague opened this issue Aug 14, 2024 · 2 comments
Closed

pulumictl and pulumi are assumed to be installed for make build #142

displague opened this issue Aug 14, 2024 · 2 comments

Comments

@displague
Copy link
Member

displague commented Aug 14, 2024 •
edited
Loading

What version of pulumi and pulumictl should be installed? The Makefile should not assume it is installed and should install a specific version of pulumictl into a build/work directory.

First pulumictl is run and much later pulumi is needed and run.
@displague displague changed the title pulumictl is assumed to be installed for make build pulumictl and pulumi are assumed to be installed for make build Aug 14, 2024
@ctreatma
Copy link
Contributor

For pulumi, at least, there is already a copy that is installed in the working directory at .pulumi/bin/pulumi, and that copy is generally used by all tasks in the Makefile. The script that generates examples was using pulumi, but #154 addresses that by updating the script to use the same local copy (.pulumi/bin/pulumi) as is used elsewhere.

@ocobles ocobles mentioned this issue Aug 20, 2024
Merged
ctreatma pushed a commit that referenced this issue Aug 20, 2024
@ocobles
chore: install pulumictl in makefile (#157)
f6e5a1f 
partially addresses #142

---------

Signed-off-by: Oscar Cobles <[email protected]>
@ctreatma
Copy link
Contributor

Closed by the combination of #154 and #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@displague @ctreatma