chore: remove make tfgen from goreleaser #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oscar Cobles <[email protected]>
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
ctreatma
reviewed
Aug 20, 2024
.goreleaser.yml
Outdated
| @@ -7,7 +7,7 @@ archives: | |||
| name_template: "{{ .Binary }}-{{ .Tag }}-{{ .Os }}-{{ .Arch }}" | |||
| before: | |||
| hooks: | |||
| - make tfgen | |||
| - make only_tfgen | |||
There was a problem hiding this comment.
I was referring to
pulumi-equinix/.github/workflows/release.yml
Lines 60 to 61 in 2146471
So it looks like we run make only_tfgen, create the GH release, and then run make tfgen again via goreleaser? In that case I think we could remove this hook entirely.
There was a problem hiding this comment.
yep I think you're right
Signed-off-by: Oscar Cobles <[email protected]>
ocobles
changed the title
ctreatma
approved these changes
Aug 20, 2024
ctreatma
pushed a commit
that referenced
this pull request
Aug 20, 2024
we need #159 merged before this one to make sure that no new changes are discovered during the release process (the `toolchain go1.22.6` in go.mod in the examples depends on the go version installed locally. In my case I have 1.22.5 while in the GH action we have 1.22.x so it can take a newer version) --------- Signed-off-by: Oscar Cobles <[email protected]>
|
This PR is included in version 0.15.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themake tfgentarget currently generate examples and that step is not necessary at all here since we only want to generate the providerRemoved entirely as per comment #159 (comment)
This comes from the discussion in #152 (comment)