Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update makefile to execute build_schema twice #164

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

ocobles
Copy link
Contributor

@ocobles ocobles commented Aug 21, 2024

Changes:

  • duplicate build_schema target (build and build_schema_post_examples) to be able to execute it twice (it didn't work even adding build_schema in PHONY). I was debugging leaving some traces to check that now it is executed twice, as expected.
  • Check that the pulumi cli installed version is the same as the one defined in provider/go.mod
  • Add export PATH := $(BIN_DIR):$(PATH). The pulumi converter command uses several plugins, on the one hand the source converter (yaml and terraform plugins in our case) and on the other hand the sdk of the language to which it is being converted, pulumi-language-python / pulumi-language-go / etc. Although the correct Pulumi CLI binary was being used with .pulumi/bin/pulumi convert ... it was taking the language binary from $PATH, so in my case /opt/homebrew/bin/ which corresponded to the Pulumi v3.122.0 version instead of the new installed v3.128.0

Originally added to #161 and opening a new PR as per #161 (comment) suggestion

Signed-off-by: Oscar Cobles <[email protected]>
@ocobles ocobles changed the title fix: update makefile to execute build schema twice fix: update makefile to execute build_schema twice Aug 21, 2024
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ocobles ocobles merged commit 02c05cc into main Aug 21, 2024
17 checks passed
@ocobles ocobles deleted the fix-makefile-build-schema branch August 21, 2024 14:48
Copy link

This PR is included in version 0.15.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants