Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade terraform-provider-equinix to v2.8.0 #216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

euclid-eqx
Copy link
Collaborator

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-title-prefix=feat: --java-version=0.16.1.


  • Updating Java Gen version to 0.16.1.
  • Upgrading terraform-provider-equinix from 2.5.0 to 2.8.0.

@euclid-eqx euclid-eqx self-assigned this Oct 15, 2024
@thogarty
Copy link

I don't think this one should be merged. It's missing important details regarding new resources. I'm actively working on creating a separate PR that will upgrade Pulumi to latest Equinix Terraform

@ctreatma
Copy link
Contributor

regarding new resources

The automated PRs intentionally do not add mappings for new resources. This is so that hand-written PRs that do add new resources can be focused on just that; otherwise those PRs are far too large to be reviewed accurately.

@thogarty
Copy link

regarding new resources

The automated PRs intentionally do not add mappings for new resources. This is so that hand-written PRs that do add new resources can be focused on just that; otherwise those PRs are far too large to be reviewed accurately.

Alright copy that. What's the right timing then? You upgrade the Pulumi to latest Terraform then add the mappings in a PR after? I was getting some errors locally saying that the mappings are needed in order to upgrade to a Terraform Version that had them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants