-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Go build remove unused imports #47
Conversation
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Signed-off-by: ocobleseqx <[email protected]>
Signed-off-by: ocobleseqx <[email protected]>
@@ -8,6 +8,7 @@ import ( | |||
"reflect" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine goimports would have removed this whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it was goimports
Have you tried https://go.dev/ref/mod#go-mod-tidy? |
This seems dangerous compared to We may be picking up development/build runtime dependencies, and if those are creating a problem we could put them in a separate go.mod. |
I didn't see |
When generating the go sdk it includes some dependencies that are not used, this produces errors during the installation of the package. I added goimports in the build_go target to remove all unused imports
There are also some updates in go.mod/go.sum files after running
go work sync
, and goreleaser file updated to run clean cache