This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Create organization request required field address #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oscar Cobles <[email protected]>
Signed-off-by: Oscar Cobles <[email protected]>
displague
reviewed
May 9, 2022
| Website *string `json:"website,omitempty"` | ||
| Twitter *string `json:"twitter,omitempty"` | ||
| Logo *string `json:"logo,omitempty"` | ||
| Address *Address `json:"address,omitempty"` |
There was a problem hiding this comment.
We could potentially send an AddressUpdateRequest object if the API supports updates to individual fields.
I think it's ok to treat the whole address object as a single entity in this, as is done here.
displague
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to field Address in OrganizationCreateRequest and OrganizationUpdateRequest.
Acceptance tests updated to validate address
fixes #332