Skip to content

Commit

Permalink
fix: variables validation
Browse files Browse the repository at this point in the history
Wrong ValidationError used when catching pydantic validation errors.
  • Loading branch information
jsolaas committed Mar 22, 2024
1 parent dc33776 commit 7a66d54
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,12 @@ def variables_raise_if_invalid(self) -> YamlVariables:

@property
def variables(self) -> YamlVariables:
"""
Get variables, invalid variable definitions will be skipped.
Returns: valid variables
"""
if not isinstance(self._internal_datamodel, dict):
return {}

Expand All @@ -275,7 +281,7 @@ def variables(self) -> YamlVariables:
reference = TypeAdapter(YamlVariableReferenceId).validate_python(reference)
variable = TypeAdapter(YamlVariable).validate_python(variable)
valid_variables[reference] = variable
except ValidationError:
except PydanticValidationError:
continue

return valid_variables
Expand Down

0 comments on commit 7a66d54

Please sign in to comment.