Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: The new update of Drogon eCalc model with a single speed pump #241

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

equinor-schen
Copy link
Contributor

Why is this pull request needed?

This pull request is needed because of a change for the Drogon eCalc model from Variable speed pump to a single speed pump

@equinor-schen equinor-schen requested a review from a team as a code owner October 16, 2023 12:49
@HeddaSvendsen HeddaSvendsen self-assigned this Oct 16, 2023
@equinor-schen equinor-schen requested a review from a team as a code owner October 16, 2023 13:13
.vscode/launch.json Outdated Show resolved Hide resolved
Copy link

@HeddaSvendsen HeddaSvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Shi. Small improvement suggestion: reduce indentation under TIME_SERIES line 70-72 and FACILITY_INPUTS line 83-92 to match the rest. See Jostein's comment about the lauch.json file, should probably not be merged.

@equinor-schen equinor-schen merged commit a22ffe8 into main Jan 22, 2024
6 checks passed
@equinor-schen equinor-schen deleted the SCHEN branch January 22, 2024 12:42
equinor-schen added a commit that referenced this pull request Aug 23, 2024
…241)

Drogon eCalc model moved from a variable speed pump to a single speed pump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants