Separate Regularity from Core #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeeeJay
force-pushed
the
ECALC-196-separate-regularity
branch
2 times, most recently
from
8057d84
to
8b226c9
Compare
jsolaas
approved these changes
Oct 19, 2023
| for key in emissions | ||
| } | ||
|
|
||
| def to_full_result( |
| @@ -903,3 +1253,35 @@ def get_results(self) -> EnergyCalculatorResult: | |||
| emission_results=self.emission_results, | |||
| variables_map=self.variables_map, | |||
| ) | |||
|
|
|||
| def convert_to_timeseries( | |||
There was a problem hiding this comment.
Not sure about the name here?
src/libecalc/dto/components.py
Outdated
| timesteps=variables_map.time_vector, | ||
| values=list( | ||
| rate.evaluate( | ||
| variables_map.get_subset_from_period(period).variables, |
There was a problem hiding this comment.
This is probably outdated?
jsolaas
force-pushed
the
ECALC-196-separate-regularity
branch
from
8b226c9
to
264edeb
Compare
Regularity should not be transferred or handled in core. At the time data arrives in core, it should only be stream day, and we should not have to relate to "what type of rate" is it, until we decide whether the user output should be calendar or stream day (default) based on user needs. Refs ECALC-196
jsolaas
force-pushed
the
ECALC-196-separate-regularity
branch
from
264edeb
to
206e69e
Compare
frodehk
pushed a commit
that referenced
this pull request
Oct 24, 2023
Regularity should not be transferred or handled in core. At the time data arrives in core, it should only be stream day, and we should not have to relate to "what type of rate" is it, until we decide whether the user output should be calendar or stream day (default) based on user needs. Refs ECALC-196
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
Regularity should not be transferred or handled in core. At the time data arrives in core, it should only be stream day, and we should not have to relate to "what type of rate" is it, until we decide whether the user output should be calendar or stream day (default) based on user needs. Refs ECALC-196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
This pull request is needed because of....
What does this pull request change?
Write summary of what this pull request changes if needed.
Issues related to this change: