refactor: calculate timesteps separately #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
force-pushed
the
refactor/point-in-time-v2
branch
2 times, most recently
from
2567733
to
dcfcb34
Compare
TeeeJay
reviewed
Nov 15, 2023
|
|
||
| ComponentID = str | ||
|
|
||
|
|
||
| @dataclass | ||
| class PriorityOptimizerResult(Generic[TResult]): | ||
| priorities_used: TimeSeriesString | ||
| priority_used: PriorityID |
TeeeJay
reviewed
Nov 15, 2023
|
|
||
| def __lt__(self, other: Pressure) -> bool: | ||
| if self.unit != other.unit: | ||
| raise ValueError("Unit mismatch") |
There was a problem hiding this comment.
We should use domain specific exceptions, but they can perhaps extend ValueError in order to easily catch higher up?
TeeeJay
approved these changes
Nov 15, 2023
olelod
reviewed
Nov 16, 2023
| self._operational_settings: Optional[CompressorOperationalSettings] = None | ||
|
|
||
| def get_max_rate(self, inlet_stream: StreamConditions, target_pressure: TimeSeriesFloat) -> List[float]: | ||
| def get_max_rate(self, inlet_stream: StreamConditions, target_pressure: Pressure) -> float: |
There was a problem hiding this comment.
Remove "For each timestep" in docstring.
Base automatically changed from
refactor/collect-priority-results-in-priority-optimizer
to
main
November 16, 2023 13:17
jsolaas
force-pushed
the
refactor/point-in-time-v2
branch
from
dcfcb34
to
f9008a7
Compare
Process one timestep at a time in v2
jsolaas
force-pushed
the
refactor/point-in-time-v2
branch
from
f9008a7
to
53e3c12
Compare
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
Process one timestep at a time in v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process one timestep at a time in v2