Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: include direct emitter results in ltp export #305
fix!: include direct emitter results in ltp export #305
Changes from all commits
bc83e3d
24a172d
e54c2e3
0519f5f
61deeeb
9210986
6124f17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are making assumptions on unit here, right? Assuming all emissions have the same unit. So setting unit_in here is to make sure it is set if the above condition (for fuel_consumers) is false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emission.rate.unit is set before the query (e.g.
t/d
), in the to_volumes() it is converted tot
. So the assumption is made earlier. The docs states that the emission rate should be in kg/day, and the assumption is done in FuelModel.evaluate_emissions(), wherekg/d
is converted tot/d
- hence, assuming input iskg/d
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, for this to fail the unit for fuel_consumers (emissions) and direct emitter would have to be different, and that is something we control.
It won't be an issue when adding units to venting_emitter either as we will convert into kg (probably). Is that something you are planning to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding unit to venting_emitter in another ongoing pr (will convert to kg as well).