Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sum and split electrical and mechanical power #406

Merged

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Mar 14, 2024

ECALC-881

Why is this pull request needed?

Power demand for directly driven compressors (FUELCONSUMERS) should be included in the total power of an installation, if not there is a risk of misinterpreting data, both in the eCalc Web plots and the csv file (the LTP file is not providing the total power so that one is OK).

What does this pull request change?

The following changes are made in graph_result:

  • Sum electrical power (ConsumptionType.ELECTRICITY) at installation level, named power_electrical.
  • Sum mechanical power (ConsumptionType.FUEL) at installation level, named power_mechanical
  • Sum electrical- and mechanical power at installation level, named power

Issues related to this change:

https://equinor-ecalc.atlassian.net/browse/ECALC-881?atlOrigin=eyJpIjoiNDk5YTI2Yzg0NjI2NDQwY2E0ZTljMTIwNTc0N2RiOTYiLCJwIjoiaiJ9

@frodehk frodehk self-assigned this Mar 14, 2024
@frodehk frodehk requested a review from a team as a code owner March 14, 2024 08:12
Copy link
Contributor

@jsolaas jsolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the consumer-dtos has a consumes property, could we use that instead of filtering on types?

src/libecalc/application/graph_result.py Outdated Show resolved Hide resolved
src/libecalc/application/graph_result.py Outdated Show resolved Hide resolved
@frodehk
Copy link
Contributor Author

frodehk commented Mar 14, 2024

I think the consumer-dtos has a consumes property, could we use that instead of filtering on types?

Done

src/libecalc/application/graph_result.py Outdated Show resolved Hide resolved
src/libecalc/application/graph_result.py Outdated Show resolved Hide resolved
@frodehk frodehk merged commit 86754cc into main Mar 15, 2024
6 checks passed
@frodehk frodehk deleted the ECALC-881-sum-and-split-electrical-and--mechanical-power branch March 15, 2024 07:51
frodehk added a commit that referenced this pull request Mar 18, 2024
* chore: sum and split electrical and mechanical power at installation level
ECALC-881
equinor-schen pushed a commit that referenced this pull request Aug 23, 2024
* chore: sum and split electrical and mechanical power at installation level
ECALC-881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants