-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sum and split electrical and mechanical power #406
Merged
frodehk
merged 6 commits into
main
from
ECALC-881-sum-and-split-electrical-and--mechanical-power
Mar 15, 2024
Merged
chore: sum and split electrical and mechanical power #406
frodehk
merged 6 commits into
main
from
ECALC-881-sum-and-split-electrical-and--mechanical-power
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
reviewed
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the consumer-dtos has a consumes
property, could we use that instead of filtering on types?
Done |
ECALC-881
jsolaas
reviewed
Mar 14, 2024
ECALC-881
ECALC-881
jsolaas
approved these changes
Mar 15, 2024
frodehk
deleted the
ECALC-881-sum-and-split-electrical-and--mechanical-power
branch
March 15, 2024 07:51
frodehk
added a commit
that referenced
this pull request
Mar 18, 2024
* chore: sum and split electrical and mechanical power at installation level ECALC-881
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* chore: sum and split electrical and mechanical power at installation level ECALC-881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-881
Why is this pull request needed?
Power demand for directly driven compressors (FUELCONSUMERS) should be included in the total power of an installation, if not there is a risk of misinterpreting data, both in the eCalc Web plots and the csv file (the LTP file is not providing the total power so that one is OK).
What does this pull request change?
The following changes are made in graph_result:
ConsumptionType.ELECTRICITY
) at installation level, namedpower_electrical
.ConsumptionType.FUEL
) at installation level, namedpower_mechanical
power
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-881?atlOrigin=eyJpIjoiNDk5YTI2Yzg0NjI2NDQwY2E0ZTljMTIwNTc0N2RiOTYiLCJwIjoiaiJ9