Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new PfS columns #429

Merged
merged 20 commits into from
Apr 18, 2024
Merged

feat: new PfS columns #429

merged 20 commits into from
Apr 18, 2024

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Apr 10, 2024

ECALC-365

Why is this pull request needed?

There’s currently two columns with PfS data in Centuries that is not reported in eCalc (LTP file). The columns are required for the RNB reporting, and thus important, but the data are currently not available in eCalc making it impossible to include it in the LTP file.

These data partly requires post-processing of the eCalc results and are often forgotten in the transfer from eCalc to Centuries.

What does this pull request change?

Possibility for additional input to eCalc at generator set level, to get the wanted data in the LTP file:

  • Add optional input for genset: cable loss factor (loss from shore) . Used if genset category is POWER-FROM-SHORE
  • Calculate Power supply onshore (including cable loss): Power required * (1 + cable loss)
  • Add optional time series of maximum PfS (Max usage from shore)
  • Report power supply onshore and max usage from shore to LTP-report
  • Add tests

Issues related to this change:

https://equinor-ecalc.atlassian.net/browse/ECALC-365?atlOrigin=eyJpIjoiOTg0YmIyNmQ3NWYwNDM4ZjliZWI0MDYwNDBlNDMxMjUiLCJwIjoiaiJ9

@frodehk frodehk self-assigned this Apr 10, 2024
@frodehk frodehk requested a review from a team as a code owner April 10, 2024 12:28
@frodehk frodehk merged commit a6b198e into main Apr 18, 2024
6 checks passed
@frodehk frodehk deleted the ECALC-365-new-pfs-columns branch April 18, 2024 11:57
equinor-schen pushed a commit that referenced this pull request Aug 23, 2024
* feat: new PfS columns

ECALC-365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants