-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new PfS columns #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodehk
force-pushed
the
ECALC-365-new-pfs-columns
branch
from
April 11, 2024 12:31
97202a1
to
bd99249
Compare
TeeeJay
reviewed
Apr 12, 2024
TeeeJay
reviewed
Apr 12, 2024
TeeeJay
reviewed
Apr 12, 2024
jsolaas
reviewed
Apr 15, 2024
frodehk
force-pushed
the
ECALC-365-new-pfs-columns
branch
from
April 15, 2024 15:06
d4433cd
to
69d6857
Compare
jsolaas
reviewed
Apr 16, 2024
src/libecalc/fixtures/cases/ltp_export/ltp_power_from_shore_yaml.py
Outdated
Show resolved
Hide resolved
jsolaas
approved these changes
Apr 18, 2024
src/tests/libecalc/presentation/yaml/yaml_models/test_pyyaml_yaml_model.py
Outdated
Show resolved
Hide resolved
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* feat: new PfS columns ECALC-365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-365
Why is this pull request needed?
There’s currently two columns with PfS data in Centuries that is not reported in eCalc (LTP file). The columns are required for the RNB reporting, and thus important, but the data are currently not available in eCalc making it impossible to include it in the LTP file.
These data partly requires post-processing of the eCalc results and are often forgotten in the transfer from eCalc to Centuries.
What does this pull request change?
Possibility for additional input to eCalc at generator set level, to get the wanted data in the LTP file:
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-365?atlOrigin=eyJpIjoiOTg0YmIyNmQ3NWYwNDM4ZjliZWI0MDYwNDBlNDMxMjUiLCJwIjoiaiJ9