chore: refine unit format alignment #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECALC-1059
ECALC-1059
TeeeJay
reviewed
Jun 4, 2024
jsolaas
approved these changes
Jun 6, 2024
TeeeJay
approved these changes
Jun 6, 2024
frodehk
added a commit
that referenced
this pull request
Jun 6, 2024
* chore: refine unit format alignment ECALC-1059 (cherry picked from commit ca14c22)
frodehk
added a commit
that referenced
this pull request
Jun 6, 2024
frodehk
added a commit
that referenced
this pull request
Jun 6, 2024
* chore: refine unit format alignment ECALC-1059 (cherry picked from commit ca14c22)
frodehk
added a commit
that referenced
this pull request
Jun 6, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* chore: refine unit format alignment ECALC-1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-1059
Have you remembered and considered?
docs/docs/changelog/next.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Simplify unit definitions in yaml. It is basically a part of the BREAKING CHANGES belonging to the #495.
What does this pull request change?
Write
SM3_PER_DAYinstead ofSTANDARD_CUBIC_METERS_PER_DAY. WriteKG_PER_DAYinstead ofKILO_PER_DAY.Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1059?atlOrigin=eyJpIjoiMzA1NzA0MTdiM2NhNDE0YmFiYTBlZmY3N2E1MzMyNjkiLCJwIjoiaiJ9