Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wrong units venting emitters docs #537

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Jun 25, 2024

ECALC-1334

Have you remembered and considered?

  • I have remembered to update documentation
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

All units for venting emitters have been changed to align with yaml input. This should be reflected in all parts of docs. Some examples still have old units.

What does this pull request change?

Update docs to have correct units for venting emitters.

Issues related to this change:

https://equinor-ecalc.atlassian.net/browse/ECALC-1334?atlOrigin=eyJpIjoiZmZmNGJhNmFhYzJmNGMzZWEzY2VlMTdmMDZiZmJkZDIiLCJwIjoiaiJ9

@frodehk frodehk self-assigned this Jun 25, 2024
@frodehk frodehk requested a review from a team as a code owner June 25, 2024 12:29
@frodehk frodehk merged commit 650a4a3 into main Jun 25, 2024
9 checks passed
@frodehk frodehk deleted the ECALC-1334-wrong-units-venting-emitters-docs-example branch June 25, 2024 12:53
jsolaas pushed a commit that referenced this pull request Jun 28, 2024
jsolaas pushed a commit that referenced this pull request Jun 28, 2024
equinor-schen pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants