refactor: move target pressure status from stages to compressor train #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
commented
Sep 4, 2024
| @@ -654,8 +654,8 @@ | |||
| ] | |||
| }, | |||
| "is_valid": [ | |||
| false, | |||
There was a problem hiding this comment.
is_valid changes for the compressor stage results because the compressor stages operate within capacity, hence the compressor stage result is valid. The compressor train is still not able to meet the required discharge pressure, so is_valid on the compressor train is still false.
chore: updated snapshots to reflect changes made ECALC-1582
olelod
force-pushed
the
refactor-compressor-trains
branch
from
5628b47
to
f16ad1d
Compare
jsolaas
approved these changes
Sep 4, 2024
|
@olelod worth a note in changelog I think, since it is not a pure refactor but also a "tiny fix", wrt incorrect flags previously for stages? |
Good point. Did not think of that. Will add one. |
frodehk
pushed a commit
that referenced
this pull request
Sep 16, 2024
…#589) chore: updated snapshots to reflect changes made ECALC-1582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move target pressures to be defined only on the compressor train, instead of also on the individual compressor stages. The target pressure status check is then also moved to the compressor train result, not on the individual compressor stage results.
Have you remembered and considered?
docs/docs/changelog/next.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Preparation to add inlet/outlet streams to compressor train result, so we can remove pressure before/after choking from the compressor stage results.
Issues related to this change:
Refs.
ECALC-1582