refactor: add inlet/outlet stream to compressor train result #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
changed the title
olelod
force-pushed
the
ECALC-1583-add-inlet/outlet-stream-to-compressor-train-result
branch
from
47c4907
to
353fbde
Compare
olelod
force-pushed
the
ECALC-1583-add-inlet/outlet-stream-to-compressor-train-result
branch
from
5357214
to
fa0692f
Compare
jsolaas
approved these changes
Sep 13, 2024
chore: update failing tests chore: update snapshots ECALC-1583
olelod
force-pushed
the
ECALC-1583-add-inlet/outlet-stream-to-compressor-train-result
branch
from
cabd7ff
to
3cb10d2
Compare
olelod
deleted the
ECALC-1583-add-inlet/outlet-stream-to-compressor-train-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you remembered and considered?
docs/docs/changelog/next.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Report the fluid streams where they are needed. An upstream choke (and potential pressure drop ahead of stage) is thought to be placed between the inlet of the compressor train and the inlet of the first compressor stage. A downstream choke is thought to be placed between the outlet of the last compressor stage and the outlet of the compressor train. Once this is defined, the confusing pressure before/after choking can be easily removed. The fluid stream (and hence pressure) is reported where needed.
What does this pull request change?
Write summary of what this pull request changes if needed.
Issues related to this change:
Refs
ECALC-1583