Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: ensure power to fuel values are strictly increasing #613

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Sep 19, 2024

BREAKING CHANGE: Do not allow power to fuel functions that are not strictly increasing or decreasing.

ECALC-1511

Have you remembered and considered?

  • I have remembered to update documentation
  • I have remembered to update manual changelog (docs/docs/changelog/next.md)
  • I have remembered to update migration guide (docs/docs/migration_guides/)
  • I have committed with BREAKING: in footer or ! in header, if breaking
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

Power to fuel function (ELECTRICITY2FUEL): The input data set is sorted by the value in the x-column in eCalc before plotting. eCalc further uses the sorted power-to-fuel function for calculations: This can lead to over-estimate fuel consumption at certain power consumptions. This is typically if the user input is not strictly increasing.

What does this pull request change?

Give resource validation error if power to fuel is not strictly increasing.

Issues related to this change:

https://equinor-ecalc.atlassian.net/browse/ECALC-1511?atlOrigin=eyJpIjoiZWJiODA5YzllZDkxNDQ0ZDhjMWU1M2YyMGM1N2E2YzAiLCJwIjoiaiJ9

@frodehk frodehk self-assigned this Sep 19, 2024
@frodehk frodehk requested a review from a team as a code owner September 19, 2024 09:06
@frodehk frodehk changed the title chore: ensure power to fuel values are strictly increasing chore!: ensure power to fuel values are strictly increasing Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant