chore!: ensure power to fuel values are strictly increasing #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Do not allow power to fuel functions that are not strictly increasing or decreasing.
ECALC-1511
Have you remembered and considered?
docs/docs/changelog/next.md
)docs/docs/migration_guides/
)BREAKING:
in footer or!
in header, if breakingECALC-XXXX
)Why is this pull request needed?
Power to fuel function (ELECTRICITY2FUEL): The input data set is sorted by the value in the x-column in eCalc before plotting. eCalc further uses the sorted power-to-fuel function for calculations: This can lead to over-estimate fuel consumption at certain power consumptions. This is typically if the user input is not strictly increasing.
What does this pull request change?
Give resource validation error if power to fuel is not strictly increasing.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1511?atlOrigin=eyJpIjoiZWJiODA5YzllZDkxNDQ0ZDhjMWU1M2YyMGM1N2E2YzAiLCJwIjoiaiJ9