Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1078 implement gamma distribution model for plus fraction characterization #1086

Conversation

Sviatose
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 36.78%. Comparing base (8b6d456) to head (b79a579).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...sim/thermo/characterization/PlusFractionModel.java 76.04% 16 Missing and 7 partials ⚠️
...a/neqsim/thermo/characterization/Characterise.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1086      +/-   ##
============================================
+ Coverage     36.54%   36.78%   +0.24%     
- Complexity     5653     5697      +44     
============================================
  Files           714      714              
  Lines         71505    71604      +99     
  Branches       8205     8222      +17     
============================================
+ Hits          26130    26341     +211     
+ Misses        43762    43635     -127     
- Partials       1613     1628      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sviatose maybe add in test an example of how to modify parameters of the gammamodel?

@EvenSol EvenSol merged commit 3b7bb38 into master Sep 4, 2024
9 checks passed
@EvenSol EvenSol deleted the 1078-implement-gamma-distribution-model-for-plus-fraction-characterization branch September 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Gamma distribution model for plus fraction characterization
3 participants